removed the usage of install-cva6.sh and add setup-env.sh #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinThomazic
requested review from
JeanRochCoulon and
zarubaf
as code owners
|
✔️ successful run, report available here. |
|
✔️ successful run, report available here. |
|
✔️ successful run, report available here. |
|
✔️ successful run, report available here. |
|
✔️ successful run, report available here. |
|
✔️ successful run, report available here. |
|
✔️ successful run, report available here. |
|
✔️ successful run, report available here. |
1 similar comment
|
✔️ successful run, report available here. |
|
✔️ successful run, report available here. |
1 similar comment
|
✔️ successful run, report available here. |
|
✔️ successful run, report available here. |
|
✔️ successful run, report available here. |
This was referenced Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to : #1727
Removed
verif/regress/install-cva6.shwhich was installing spike, verilator but also setting the env variables for simulation despite its name.Removed
verif/regress/install-riscv-dv.shsince it was also setting sim env variables and trying to install python packages each time it was run.Instead,
verif/regress/install-verilator.shandverif/regress/install-spike.share directly used to install verilator and spike and a new fileverif/sim/setup-env.shsets the env variables for simulations.Removed the ("broken" see #1737) install skip mechanism in the process, which was only used once in
gitlab-ci.yml.Instead, the installation scripts are simply not run.
Updated the
READMEaccordingly.